Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dialog: add localization support to dialog #402

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

Adds localization support to BaseDialog and Dialog

JIRA TASK (Eightfold Employees Only):

ENG-30997

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist (loc tests)
  • I have added unittests for this change

TEST PLAN:

Pull the pr branch and do yarn, then yarn storybook, verify the Dialog stories behave as expected.

Set the Dialog locale to another language and test the go to text as follows (pseudo-code):

import { zhCN } from "@eightfold.ai/octuple/";
<Dialog locale={zhCN} okText={'foo'} />

The ok button text in the Dialog should read 'foo' and the others should use the loc defaults.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 30, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d7ce941:

Sandbox Source
React Configuration
Vanilla Configuration

@dkilgore-eightfold dkilgore-eightfold merged commit 25366c9 into EightfoldAI:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants