feat: dialog: add localization support to dialog #402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Adds localization support to
BaseDialog
andDialog
JIRA TASK (Eightfold Employees Only):
ENG-30997
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the pr branch and do
yarn
, thenyarn storybook
, verify theDialog
stories behave as expected.Set the Dialog locale to another language and test the go to text as follows (pseudo-code):
The ok button text in the
Dialog
should read 'foo' and the others should use the loc defaults.