-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: progress: add progress component to octuple #420
feat: progress: add progress component to octuple #420
Conversation
consolidates reset component and clear fix mixins, fixes tree import type
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eea5d60:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
=======================================
Coverage ? 85.00%
=======================================
Files ? 667
Lines ? 14448
Branches ? 5006
=======================================
Hits ? 12282
Misses ? 2107
Partials ? 59 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
SUMMARY:
This change adds the Progress component to Octuple.
-Also consolidates reset component and clear-fix mixins, fixes tree import type so the filter tree expand/collapse actually works.
progress.mp4
Octuple DS Figma spec: https://www.figma.com/file/SlKRC7oKF7XZyHMv2op4ch/Octuple-DS-(Theme-2)?node-id=7994%3A24301
JIRA TASK (Eightfold Employees Only):
ENG-2822
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the pr feature branch, then do
yarn
andyarn storybook
. Verify the Progress stories behave as expected.