Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: progress: add progress component to octuple #420

Conversation

dkilgore-eightfold
Copy link
Contributor

@dkilgore-eightfold dkilgore-eightfold commented Oct 13, 2022

SUMMARY:

This change adds the Progress component to Octuple.

-Also consolidates reset component and clear-fix mixins, fixes tree import type so the filter tree expand/collapse actually works.

progress.mp4

Octuple DS Figma spec: https://www.figma.com/file/SlKRC7oKF7XZyHMv2op4ch/Octuple-DS-(Theme-2)?node-id=7994%3A24301

JIRA TASK (Eightfold Employees Only):

ENG-2822

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the pr feature branch, then do yarn and yarn storybook. Verify the Progress stories behave as expected.

consolidates reset component and clear fix mixins, fixes tree import type
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 13, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eea5d60:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@f1cd077). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #420   +/-   ##
=======================================
  Coverage        ?   85.00%           
=======================================
  Files           ?      667           
  Lines           ?    14448           
  Branches        ?     5006           
=======================================
  Hits            ?    12282           
  Misses          ?     2107           
  Partials        ?       59           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/components/Progress/Circle.tsx Show resolved Hide resolved
src/components/Progress/Circle.tsx Outdated Show resolved Hide resolved
src/components/Progress/Circle.tsx Outdated Show resolved Hide resolved
src/components/Progress/Circle.tsx Outdated Show resolved Hide resolved
src/components/Progress/Circle.tsx Outdated Show resolved Hide resolved
src/components/Progress/Internal/OcCircle.tsx Outdated Show resolved Hide resolved
src/components/Progress/Internal/OcLine.tsx Outdated Show resolved Hide resolved
src/components/Progress/Internal/OcLine.tsx Show resolved Hide resolved
src/components/Progress/Internal/hooks/useId.ts Outdated Show resolved Hide resolved
src/components/Progress/Steps.tsx Show resolved Hide resolved
@dkilgore-eightfold dkilgore-eightfold merged commit aa1ad1d into EightfoldAI:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants