feat: add support for autocomplete attribute to TextInput and SearchBox #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e2f6027:
|
dkilgore-eightfold
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Add missing support for autocomplete attribute so we can disable this in search circumstances where the autocomplete interferes with custom autocomplete implementations
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
In Storybook, inspect element in devtools to confirm there is no autocomplete attribute on the element. Add a value "off" and observe that the attribute and value are added to the Input as expected