Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove padding from borderless stat-tabs, extend varTheme #470

Merged

Conversation

jhoward-eightfold
Copy link
Contributor

SUMMARY:

When turning off border for StatTabs, remove the padding as designers will most often want the tabs flush with the surrounding content.

Additional enhancements to varTheme support.

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Visual inspection of StatTabs to ensure they render as desired.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 16, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bc58fd6:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@3554159). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #470   +/-   ##
=======================================
  Coverage        ?   84.99%           
=======================================
  Files           ?      749           
  Lines           ?    16047           
  Branches        ?     5495           
=======================================
  Hits            ?    13639           
  Misses          ?     2347           
  Partials        ?       61           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jhoward-eightfold jhoward-eightfold merged commit c70f2dd into EightfoldAI:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants