Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id prop passed to TextArea is taking dynamic values in rendered HTML #496

Closed
lpatel-eightfold opened this issue Jan 9, 2023 · 2 comments
Labels
bug Something isn't working ticketed-internal Issue has an active ticket

Comments

@lpatel-eightfold
Copy link
Contributor

lpatel-eightfold commented Jan 9, 2023

The id prop passed to TextArea component, should ideally remain unchanged in the final HTML. But instead a number gets appended to the end of the passed id.
The issue can be reproduced on the storybook site as well:
https://eightfoldai.github.io/octuple.github.io/?path=/story/input--text-area&args=id:myId

Screenshot 2023-01-09 at 20 03 34

@dkilgore-eightfold
Copy link
Contributor

@lpatel-eightfold noted, in the meantime if your goal is to use the id for test purposes, please use data-test-id instead. If using for css, consider using the classNames prop.

@dkilgore-eightfold dkilgore-eightfold added bug Something isn't working ticketed-internal Issue has an active ticket labels Jan 10, 2023
@dkilgore-eightfold
Copy link
Contributor

Tracking with ENG-39552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ticketed-internal Issue has an active ticket
Projects
None yet
Development

No branches or pull requests

2 participants