Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown now stays within the viewport #512

Conversation

fmehta-eightfold
Copy link
Contributor

SUMMARY:

CSS change to ensure dropdown menu stays within the viewport

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

ENG-39856

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Ensure https://eightfoldai.github.io/octuple.github.io/?path=/story/dropdown--dropdown-button continues to work as expected.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 85d53f7:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@f97a7df). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #512   +/-   ##
=======================================
  Coverage        ?   84.76%           
=======================================
  Files           ?      785           
  Lines           ?    16451           
  Branches        ?     5696           
=======================================
  Hits            ?    13944           
  Misses          ?     2441           
  Partials        ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dkilgore-eightfold dkilgore-eightfold merged commit d93f0fd into EightfoldAI:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants