-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: preserve case in Select #519
fix: preserve case in Select #519
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d89990a:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
=======================================
Coverage ? 84.76%
=======================================
Files ? 789
Lines ? 16548
Branches ? 5735
=======================================
Hits ? 14027
Misses ? 2454
Partials ? 67 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Mohammed Fazil <109717425+mfazil-eightfold@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on PCS and lgtm
SUMMARY:
Preserve input case when calling
loadOptions
andfilterOption
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
ENG-39555
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Refer my comment in ENG-39555