Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve case in Select #519

Conversation

fmehta-eightfold
Copy link
Contributor

SUMMARY:

Preserve input case when calling loadOptions and filterOption

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

ENG-39555

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Refer my comment in ENG-39555

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 30, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d89990a:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@c402df3). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #519   +/-   ##
=======================================
  Coverage        ?   84.76%           
=======================================
  Files           ?      789           
  Lines           ?    16548           
  Branches        ?     5735           
=======================================
  Hits            ?    14027           
  Misses          ?     2454           
  Partials        ?       67           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

fmehta-eightfold and others added 2 commits February 1, 2023 14:00
Co-authored-by: Mohammed Fazil <109717425+mfazil-eightfold@users.noreply.github.com>
Copy link

@slee-eightfold slee-eightfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on PCS and lgtm

@fmehta-eightfold fmehta-eightfold merged commit 9427fcd into EightfoldAI:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants