-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: slider: enable basic data comparison slider implementations #529
feat: slider: enable basic data comparison slider implementations #529
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0f237ca:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
=======================================
Coverage ? 84.82%
=======================================
Files ? 789
Lines ? 16574
Branches ? 5761
=======================================
Hits ? 14059
Misses ? 2448
Partials ? 67 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with comments
SUMMARY:
Enables Data Comparison implementations of
Slider
and extends customizability.Bug fixes:
thumbGeometry
function and updated logic inupdateLayout
gipper
andgripping
SliderSize
enumSliderMarker
for internal usereadOnly
to<input>
ifSlider
isreadOnly
key
toTooltip
changeToCloseValue
function handling whenreadOnly
Features:
Slider
Slider
track and rail viahideTrack
andhideRail
propsSlider
viatrackColor
propSliderTrackColor
enumSlider
dots
custom classes viadotClassNames
propdataSlider.mp4
JIRA TASK (Eightfold Employees Only):
ENG-32662
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
andyarn storybook
. Verify theSlider
stories behave as expected.