Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: slider: enable basic data comparison slider implementations #529

Conversation

dkilgore-eightfold
Copy link
Contributor

@dkilgore-eightfold dkilgore-eightfold commented Feb 2, 2023

SUMMARY:

Enables Data Comparison implementations of Slider and extends customizability.

Bug fixes:

  • Fixes thumb value position with custom inline extremity label offset and marker offset via thumbGeometry function and updated logic in updateLayout
  • Fixes thumb cursor to use gipper and gripping
  • Exports SliderSize enum
  • Fixes marks prop by exposing full SliderMarker for internal use
  • Adds some typing
  • Add readOnly to <input> if Slider is readOnly
  • Adds key to Tooltip
  • Ensure changeToCloseValue function handling when readOnly

Features:

  • Adds Benchmark Slider Story
  • Adds Data Inactive Story
  • Adds Data Active Story
  • Extends varTheme support of Slider
  • Demonstrates how to use SVGs as markers
  • Provides Data Comparison SVGs for quick reference
  • Adds Ability to hide the Slider track and rail via hideTrack and hideRail props
  • Adds ability to quickly update the track color of Slider via trackColor prop SliderTrackColor enum
  • Adds ability to give Slider dots custom classes via dotClassNames prop
dataSlider.mp4

JIRA TASK (Eightfold Employees Only):

ENG-32662

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Slider stories behave as expected.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0f237ca:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@5e121cb). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #529   +/-   ##
=======================================
  Coverage        ?   84.82%           
=======================================
  Files           ?      789           
  Lines           ?    16574           
  Branches        ?     5761           
=======================================
  Hits            ?    14059           
  Misses          ?     2448           
  Partials        ?       67           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jhoward-eightfold jhoward-eightfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with comments

src/components/Slider/slider.module.scss Show resolved Hide resolved
src/styles/themes/_default-theme.scss Outdated Show resolved Hide resolved
@dkilgore-eightfold dkilgore-eightfold merged commit 7c6bae2 into EightfoldAI:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants