Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add secondary button in menu item #540

Merged

Conversation

ychhabra-eightfold
Copy link
Collaborator

SUMMARY:

feat: add secondary button in menu item

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c31583a:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@4242cc9). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #540   +/-   ##
=======================================
  Coverage        ?   84.68%           
=======================================
  Files           ?      789           
  Lines           ?    16595           
  Branches        ?     5776           
=======================================
  Hits            ?    14054           
  Misses          ?     2475           
  Partials        ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dkilgore-eightfold
Copy link
Contributor

@ypike-eightfold This change adds a feature not yet available in the DS Figma:

secondaryMenuButton

It adds an additional button within Menu for actions like delete.

@ychhabra-eightfold ychhabra-eightfold merged commit e75f047 into EightfoldAI:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants