Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select: improves select by adding props and enabling default value array #545

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Improves defaultValue to be a union of string | string[] so multiple mode Select may have multiple default selected options
  • Adds autocomplete, onBlur, onFocus, and onKeydown props
  • Adds 19 additional unit tests to verify changes in this PR and existing functionality
  • Fixes null reference error when element is undefined in isPillEllipsisActive function in multiple mode
  • Removes console log from Dropdown
defaultValueImproved.mp4

JIRA TASK (Eightfold Employees Only):

ENG-29678

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn, and yarn storybook. Verify the Select stories behave as expected.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 22, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aa22b54:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@49340dd). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #545   +/-   ##
=======================================
  Coverage        ?   84.66%           
=======================================
  Files           ?      790           
  Lines           ?    16783           
  Branches        ?     5889           
=======================================
  Hits            ?    14210           
  Misses          ?     2507           
  Partials        ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@slee-eightfold slee-eightfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on PCS as expected

@dkilgore-eightfold dkilgore-eightfold merged commit 1b13981 into EightfoldAI:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants