-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: select: improves select by adding props and enabling default value array #545
fix: select: improves select by adding props and enabling default value array #545
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit aa22b54:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
=======================================
Coverage ? 84.66%
=======================================
Files ? 790
Lines ? 16783
Branches ? 5889
=======================================
Hits ? 14210
Misses ? 2507
Partials ? 66 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works on PCS as expected
SUMMARY:
defaultValue
to be a union ofstring | string[]
somultiple
modeSelect
may have multiple default selected optionsautocomplete
,onBlur
,onFocus
, andonKeydown
propsisPillEllipsisActive
function inmultiple
modeDropdown
defaultValueImproved.mp4
JIRA TASK (Eightfold Employees Only):
ENG-29678
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
, andyarn storybook
. Verify theSelect
stories behave as expected.