Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bodyPadding prop on Panel does not work #565

Closed
jhoward-eightfold opened this issue Mar 16, 2023 · 2 comments
Closed

bodyPadding prop on Panel does not work #565

jhoward-eightfold opened this issue Mar 16, 2023 · 2 comments
Assignees
Labels
bug Something isn't working ticketed-internal Issue has an active ticket

Comments

@jhoward-eightfold
Copy link
Contributor

jhoward-eightfold commented Mar 16, 2023

Toggling bodyPadding prop does not disable body padding IF AND ONLY IF headerPadding is disabled

Screenshot 2023-03-16 at 10 29 08 AM

@dkilgore-eightfold
Copy link
Contributor

Looks like a SASS bug.

https://github.com/EightfoldAI/octuple/blob/main/src/components/Panel/panel.module.scss#L113-L137

  &.no-body-padding {
      padding: 0;

      .header {
        padding: $space-l $space-xl $space-m $space-xl; // BUG?
      }

      .footer {
        padding: $space-m $space-xl $space-l $space-xl; // BUG?
      }
    }

    &.no-header-padding {
      padding: 0;
      .header {
        padding: 0;
      }
      .body {
        padding: 0 $space-xl; // BUG
      }
      .footer {
        padding: $space-m $space-xl $space-l $space-xl; // BUG?
      }
    }

@dkilgore-eightfold dkilgore-eightfold self-assigned this Mar 16, 2023
@dkilgore-eightfold dkilgore-eightfold added bug Something isn't working ticketed-internal Issue has an active ticket labels Mar 16, 2023
@dkilgore-eightfold
Copy link
Contributor

Tracking with ENG-46504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ticketed-internal Issue has an active ticket
Projects
None yet
Development

No branches or pull requests

2 participants