Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inline svg component #583

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

jhoward-eightfold
Copy link
Contributor

SUMMARY:

Adds a component for rendering an SVG inline in the document so that it can be styled/colored with css vars and easily themed.

Screen.Recording.2023-04-06.at.8.41.12.AM.mov

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  • Pull code, Observe in storybook
  • Unit test coverage

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dd75197:

Sandbox Source
React Configuration
Vanilla Configuration

src/components/InlineSvg/InlineSvg.tsx Outdated Show resolved Hide resolved
src/components/InlineSvg/InlineSvg.tsx Outdated Show resolved Hide resolved
src/components/InlineSvg/InlineSvg.tsx Outdated Show resolved Hide resolved
src/components/InlineSvg/InlineSvg.types.ts Outdated Show resolved Hide resolved
src/components/InlineSvg/InlineSvg.tsx Outdated Show resolved Hide resolved
@jhoward-eightfold jhoward-eightfold merged commit 76836a0 into EightfoldAI:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants