Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: button: move three more button palettes to global css vars #593

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Moves NeutralButton, SystemUIButton and TwoStateButton color palettes to global CSS variables
  • Moves split divider colors to global CSS variables
buttonVars.mp4

JIRA TASK (Eightfold Employees Only):

ENG-49421

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Button stories behave as expected.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 11, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b53701b:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@32682a6). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #593   +/-   ##
=======================================
  Coverage        ?   84.88%           
=======================================
  Files           ?      793           
  Lines           ?    17193           
  Branches        ?     6059           
=======================================
  Hits            ?    14595           
  Misses          ?     2532           
  Partials        ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/styles/themes/_default-theme.scss Show resolved Hide resolved
src/styles/themes/_default-theme.scss Outdated Show resolved Hide resolved
@dkilgore-eightfold dkilgore-eightfold merged commit f4e3ac5 into EightfoldAI:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants