Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sass: moves scroll bars mixin to global scope and adds it to dropdown #726

Conversation

dkilgore-eightfold
Copy link
Contributor

@dkilgore-eightfold dkilgore-eightfold commented Oct 17, 2023

SUMMARY:

Moves scroll-bars mixin to global scope, add it to Dropdown module to achieve improved scroll bar styles.

scrollBarsMixin.mp4

Scrollbar should be consistent in webkit browsers. Firefox is the outlier, where I'm still investigating a fix.

JIRA TASK (Eightfold Employees Only):

ENG-68019

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist (storybook CSS only)
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Dropdown, Menu, Select, DatePicker choose time, and TimePicker stories behave as expected.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 17, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 52ff0b0:

Sandbox Source
React Configuration

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b6af71) 85.04% compared to head (52ff0b0) 85.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #726   +/-   ##
=======================================
  Coverage   85.04%   85.05%           
=======================================
  Files         999      999           
  Lines       19255    19255           
  Branches     7112     7112           
=======================================
+ Hits        16376    16377    +1     
+ Misses       2797     2796    -1     
  Partials       82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkilgore-eightfold dkilgore-eightfold merged commit 501ddce into EightfoldAI:main Jan 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants