-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sass: moves scroll bars mixin to global scope and adds it to dropdown #726
fix: sass: moves scroll bars mixin to global scope and adds it to dropdown #726
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 52ff0b0:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
=======================================
Coverage 85.04% 85.05%
=======================================
Files 999 999
Lines 19255 19255
Branches 7112 7112
=======================================
+ Hits 16376 16377 +1
+ Misses 2797 2796 -1
Partials 82 82 ☔ View full report in Codecov by Sentry. |
SUMMARY:
Moves
scroll-bars
mixin to global scope, add it toDropdown
module to achieve improved scroll bar styles.scrollBarsMixin.mp4
Scrollbar should be consistent in webkit browsers. Firefox is the outlier, where I'm still investigating a fix.
JIRA TASK (Eightfold Employees Only):
ENG-68019
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
andyarn storybook
. Verify theDropdown
,Menu
,Select
,DatePicker
choose time, andTimePicker
stories behave as expected.