Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grid: adds xl breakpoint #762

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Adds xl breakpoint (1600px)
  • Adds UTs
  • Updates Grid stories where necessary
  • Updates MANIFEST.md to include the dependencies
  • Fixes typo in README.md
  • Enable basic SSR support by comparing for window or document where they are referenced, as well as validating window when request animation frame or cancel animation frame methods are used.
breakpoint.mp4

JIRA TASK (Eightfold Employees Only):

ENG-54729

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Grid stories behave as expected.

Copy link

codesandbox-ci bot commented Jan 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1a77bf6:

Sandbox Source
React Configuration

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 156 lines in your changes are missing coverage. Please review.

Comparison is base (501ddce) 85.03% compared to head (1a77bf6) 84.86%.

Files Patch % Lines
src/components/Upload/Cropper/Cropper.tsx 0.00% 51 Missing ⚠️
src/shared/utilities/css.ts 40.00% 21 Missing ⚠️
src/components/Carousel/Carousel.tsx 0.00% 16 Missing ⚠️
.../DateTimePicker/Internal/Tests/util/commonUtil.tsx 68.75% 10 Missing ⚠️
src/hooks/useFontSize.ts 0.00% 7 Missing ⚠️
src/components/Dialog/DialogHelper.tsx 0.00% 5 Missing ⚠️
...omponents/ConfigProvider/Theming/styleGenerator.ts 81.81% 4 Missing ⚠️
src/components/Skill/SkillBlock.tsx 55.55% 4 Missing ⚠️
...omponents/Table/Hooks/useFilter/FilterDropdown.tsx 42.85% 4 Missing ⚠️
src/components/Trigger/Trigger.tsx 73.33% 4 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
- Coverage   85.03%   84.86%   -0.18%     
==========================================
  Files         999      999              
  Lines       19255    19407     +152     
  Branches     7112     7221     +109     
==========================================
+ Hits        16374    16469      +95     
- Misses       2799     2856      +57     
  Partials       82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/components/Align/util.ts Outdated Show resolved Hide resolved
src/components/Align/util.ts Outdated Show resolved Hide resolved
src/components/Carousel/Carousel.tsx Outdated Show resolved Hide resolved
src/components/Carousel/Carousel.tsx Outdated Show resolved Hide resolved
src/components/DateTimePicker/Internal/Utils/uiUtil.ts Outdated Show resolved Hide resolved
src/components/DateTimePicker/Internal/Utils/uiUtil.ts Outdated Show resolved Hide resolved
src/components/Dialog/DialogHelper.tsx Outdated Show resolved Hide resolved
src/components/Form/Hooks/useForm.ts Outdated Show resolved Hide resolved
src/components/InlineSvg/InlineSvg.tsx Outdated Show resolved Hide resolved
@dkilgore-eightfold dkilgore-eightfold merged commit 57f8131 into EightfoldAI:main Jan 9, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants