Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input: updates validation status font color to latest specification #771

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Updates the default text validation status input font colors to --text-primary-color so they are consistent with invalidated state, deferring visual cue to its border and inline validation text

validationFontColorCorrected

JIRA TASK (Eightfold Employees Only):

ENG-65381

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Form stories behave as expected.

Copy link

codesandbox-ci bot commented Jan 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9354c22:

Sandbox Source
React Configuration

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (268b54f) 84.86% compared to head (9354c22) 84.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #771      +/-   ##
==========================================
- Coverage   84.86%   84.85%   -0.01%     
==========================================
  Files         999      999              
  Lines       19411    19411              
  Branches     7224     7224              
==========================================
- Hits        16473    16472       -1     
- Misses       2856     2857       +1     
  Partials       82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkilgore-eightfold dkilgore-eightfold merged commit 8df221c into EightfoldAI:main Jan 9, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants