Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tabs: alignIcon for default and pill and updates stat to add xsmall and optional button #780

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Adds alignIcon prop and its TabIconAlign enum with Start and End options support to default and pill variants
  • Adds buttonProps for an optional button per Stat for stat variant
  • Adds XSmall to TabSize options to support extra small Stat Tabs size, this is mapped to Small for default and pill variants
  • Adds Stories
  • Adds unit tests
tabsUpdates.mp4

JIRA TASK (Eightfold Employees Only):

ENG-77358

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Tabs and Stat Tabs stories behave as expected.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5b6067d:

Sandbox Source
React Configuration

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (adfb54d) 84.82% compared to head (5b6067d) 84.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
+ Coverage   84.82%   84.84%   +0.01%     
==========================================
  Files         999      999              
  Lines       19531    19542      +11     
  Branches     7284     7292       +8     
==========================================
+ Hits        16568    16580      +12     
+ Misses       2883     2882       -1     
  Partials       80       80              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkilgore-eightfold dkilgore-eightfold merged commit 4d1d324 into EightfoldAI:main Feb 1, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants