Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: infobar: reflow to support small screens according to latest design spec #798

Conversation

dkilgore-eightfold
Copy link
Contributor

@dkilgore-eightfold dkilgore-eightfold commented Mar 18, 2024

SUMMARY:

Prior to this change, the optional action button did not reflow.

  • Updates SASS modules to reflow at breakpoints specified
  • Updates InfoBar padding to latest spec
  • Adds the following props to enable greater customization of InfoBar: actionButtonClassNames, contentClassNames, contentWrapperClassNames, iconClassNames
  • Updates Snackbar to implement the same reflow relative to its size.
infoBarReflow.mp4

JIRA TASK (Eightfold Employees Only):

ENG-79502

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist (Storybook)
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the InfoBar and Snackbar stories behave as expected.

Copy link

codesandbox-ci bot commented Mar 18, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (bb17b93) to head (9b0dc11).

❗ Current head 9b0dc11 differs from pull request most recent head fac8aa9. Consider uploading reports for the commit fac8aa9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
- Coverage   84.38%   84.37%   -0.02%     
==========================================
  Files        1009     1009              
  Lines       19909    19896      -13     
  Branches     7546     7540       -6     
==========================================
- Hits        16800    16787      -13     
- Misses       3025     3026       +1     
+ Partials       84       83       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkilgore-eightfold dkilgore-eightfold merged commit 3cf3525 into EightfoldAI:main Apr 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants