feat: accordion: adds rendercontentalways prop managed by expanded #816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
renderContentAlways
prop toAccordion
, improving keyboard and assistive tech usability config upstreamWe useEffect to first check if
renderContentAlways
istrue
. If it is, we setshouldRender
totrue
and skip the rest of the checks. IfrenderContentAlways
isfalse
, we then check ifexpanded
istrue
. If it is, we setshouldRender
totrue
and clear any existing timeout. Ifexpanded
isfalse
, we start a timeout that setsshouldRender
tofalse
after400ms
, affording time for the animation to complete.accordion.mp4
JIRA TASK (Eightfold Employees Only):
ENG-86284
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
andyarn storybook
. Verify theAccordion
stories behave as expected.