Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accordion: adds rendercontentalways prop managed by expanded #816

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Adds renderContentAlways prop to Accordion, improving keyboard and assistive tech usability config upstream
  • Adds UTs
  • Updates Stories

We useEffect to first check if renderContentAlways is true. If it is, we set shouldRender to true and skip the rest of the checks. If renderContentAlways is false, we then check if expanded is true. If it is, we set shouldRender to true and clear any existing timeout. If expanded is false, we start a timeout that sets shouldRender to false after 400ms, affording time for the animation to complete.

accordion.mp4

JIRA TASK (Eightfold Employees Only):

ENG-86284

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Accordion stories behave as expected.

Copy link

codesandbox-ci bot commented Apr 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

src/components/Accordion/Accordion.tsx Outdated Show resolved Hide resolved
src/components/Accordion/Accordion.tsx Outdated Show resolved Hide resolved
src/components/Accordion/Accordion.tsx Show resolved Hide resolved
@dkilgore-eightfold dkilgore-eightfold merged commit 891d37e into EightfoldAI:main Apr 17, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants