-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: feature flags: Add feature flag config for Octuple #875
feat: feature flags: Add feature flag config for Octuple #875
Conversation
Add option to lazy load panels by default
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
I'm curious if this is the direction we want to go in for shipping Octuple changes faster. Also, it might be a bit more complex to debug if component-level props are being ignored for context-level props. If we decide we want to continue with feature flags though, I think we should:
export interface FeatureFlags {
panel?: {
/**
* If `true`, the panel content will render ONLY when `visible` is `true`.
* Otherwise, the panel content will default to the `renderContentAlways` value.
*
* < some information about when/why this should be used >
*/
lazyLoadContent?: boolean;
}
} |
* feat: feature flags: Add feature flag config for Octuple Add option to lazy load panels by default * rename property * add jsdoc for the flag
Add a feature flag config for octuple which can provide a mechanism to provide default behavior for Octuple components.
SUMMARY:
This adds a feature flag config, and creates one flag that can control the way that Panels are rendered
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Open the panel in storybook, and toggle the
lazyLoadPanelContent
flag in the settings. You should be able to see that the panel contents are rendered or not rendered even when the panel is not visible