Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select: remove toggle button from tab order #883

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

jhoward-eightfold
Copy link
Contributor

SUMMARY:

This removes focusability from the button in Select components. This resolves an accessibility and usability issue in which the Select component input is focusable in order to open the dropdown, and the button provides unnecessary duplication of that action.

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  • Pull down code
  • run storybook
  • confirm that select component still works as desired:
    • can open the dropdown while keyboard focused on the input
    • can open the dropdown by click on the input and/or the toggle button

Copy link

codesandbox-ci bot commented Aug 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@jhoward-eightfold jhoward-eightfold merged commit 3b40820 into EightfoldAI:main Aug 27, 2024
3 of 4 checks passed
jhoward-eightfold added a commit that referenced this pull request Aug 27, 2024
* fix: select: remove toggle button from tab order

* fix: update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants