fix: accordion: remove role presentation and add default aria-label on expand toggle button for a11y #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysarvaiya-c-eightfold
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
needs_sandbox:3 |
jhoward-eightfold
approved these changes
Sep 4, 2024
jhoward-eightfold
added a commit
that referenced
this pull request
Sep 9, 2024
…n expand toggle button for a11y (#887) * fix: accordian: remove role presentation on expand button * fix: accordian: add default ariaLabel on expand button * fix: accordion: add aria label back to the expand button --------- Co-authored-by: Jeff Howard <106610186+jhoward-eightfold@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
This change removes the role of presentation from expand toggle button and Added default aria-label on expand toggle button of accordion for resolving accessibility issue.
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-107391
https://eightfoldai.atlassian.net/browse/ENG-107372
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull branch down locally and run
yarn storybook.(
http://localhost:2022/?path=/story/accordion--single)Confirm that expand button in accordion component does not have
role="presentation"Confirm that
expandButtonPropshas default ariaLabel prop. and expand button has aria-label="Toggle accordion"Confirm that in accessibility tab in control that it does not violate 'Buttons must have discernible text' rule.