Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove focus visible #906

Merged
merged 1 commit into from
Nov 11, 2024
Merged

feat: remove focus visible #906

merged 1 commit into from
Nov 11, 2024

Conversation

sravichandran-eightfold
Copy link
Collaborator

SUMMARY:

This removes the focus visible that was added as part of a PR in the octuple design language.
The PR in contention is #899

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-113537

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

The existing test plan should take care of it. This is removing a CSS fix

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.60%. Comparing base (0e1730e) to head (549743a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #906   +/-   ##
=======================================
  Coverage   84.60%   84.60%           
=======================================
  Files        1100     1100           
  Lines       20486    20486           
  Branches     7744     7744           
=======================================
  Hits        17332    17332           
  Misses       3067     3067           
  Partials       87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sravichandran-eightfold sravichandran-eightfold merged commit dd6eb34 into main Nov 11, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants