-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for newline at the end of file #399
Comments
I can have a look and see it this can be fixed |
This can be implemented in PatchedXMLWriter:
First, I need to ask: Does this issue cause problems for you? And how in that case? |
🤦 I just realised that spotless is actually using my plugin to process the pom-files. I'll contact them and ask if there are general settings for endWithNewline that I can support. |
Well, it is actually not rolled out yet |
Many thanks @Ekryd ! |
Released version 3.4.0 with support for the new parameter |
Currently the plugin enforces the presence of a new line at the end of file; if the new line is not there it will be added by the sort phase. This may or may not be desirable thus usually formatting plugins leave the decision to the user (e.g., spotless provides
endWithNewline
config).Ideally the presence of new line at the end of file should be configurable. For my use-case it would be also acceptable if the new line is not added at all by this plugin since if necessary I could achieve the same effect with other means (i.e., spotless).
The text was updated successfully, but these errors were encountered: