-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attributes resulting in long lines should be wrapped or chopped down #412
Comments
I took a look at the code. If there is interest, I'll happily submit a PR that adds the following:
My example above would be formatted as such: <scm
child.scm.connection.inherit.append.path="false"
child.scm.developerConnection.inherit.append.path="false"
child.scm.url.inherit.append.path="false">
...
</scm> Essentially, when |
Hi! This sounds interesting. A PR is always welcome. |
Sounds good! I'll submit one soon and will reference this issue when I do.
"Chop down" is the terminology that JetBrains uses in their products. I'm not aware of common terminology beyond that, unfortunately. I can do
As an attribute, yes, I think it would also have to affect
|
Actually, I'll just do
|
Just a quick note: I will keep the "2 * nrOfIndentSpace + 1 space" indentation you use for |
I believe that the 2 * 🤔 Naming is one of the hardest things in programming. Don't let my suggestions interrupt your work too much. Create some code and we can look at it together. |
I created the branch |
Hello again! I wrote some code for this as this change would affect another major build.
If you are interested, please add support for 'skipFirst' which would only indent the second attribute and 'project' which would indent only everything in the project tag and ignore the rest of the attributes. |
@Ekryd: Fantastic to see this! I'm sorry I wasn't able to get a PR up sooner: Life kept unexpectedly pushing back my available windows for working on other people's OSS projects. To show my appreciation for your work, and as an apology for not being able to get to work on this myself as anticipated, I made a one-time contribution towards the project via GitHub's sponsorship feature. All the best! |
Thanks a lot @winniequinn !! |
I have the following in a POM (due to MNG-6059):
After formatting, unfortunately, I am stuck with this:
While not the end of the world, it would be nice if there were an option to wrap or chop down attributes when an element featuring them would otherwise exceed some reasonable length. This would generalize the current
indentSchemaLocation
option.The text was updated successfully, but these errors were encountered: