Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove report breach #56

Merged
merged 1 commit into from
Jun 13, 2024
Merged

remove report breach #56

merged 1 commit into from
Jun 13, 2024

Conversation

moodysalem
Copy link
Member

@moodysalem moodysalem commented Jun 13, 2024

The purpose of this method is unclear

In addition, it can be used to cancel a proposal after voting has started. E.g. delegate to new account, create proposal from new account, wait for everyone to vote, then undelegate and report breach on the proposal

Instead, users of these contracts should consider increasing voting delay, which allows more time for cancellation and undelegating to the proposer if it is undesirable

@moodysalem moodysalem marked this pull request as ready for review June 13, 2024 18:18
@moodysalem moodysalem merged commit 231e070 into main Jun 13, 2024
1 check passed
@moodysalem moodysalem deleted the remove-report-breach-v2 branch June 13, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant