Removes the backwards compatibility of storage for governor config #60
Conversation
| @@ -405,11 +410,7 @@ pub mod Governor { | |||
| } | |||
|
|
|||
| fn get_config_version(self: @ContractState, version: u64) -> Config { | |||
There was a problem hiding this comment.
to rename get_config? or get_config_by_version ?
it returns a Config, not a version, get_config_version is probably not the better name for this function?
There was a problem hiding this comment.
agreed, but slightly concerned about breaking compatibility with any calling contracts, and it's also confusing with get_config_with_version anyway
| execution_delay: 0, | ||
| execution_window: 0 | ||
| } | ||
| ) |
There was a problem hiding this comment.
code looks good!
can you explain me what you mean exactly by // Migrates to the fixed storage layout, i.e. the storage layout from before v2.1.0 in the interface?
For me you just removed the config variable in storage, reset all storage slot of the config to 0 using Store trait that replaced StorageAccess in v 2.1.0, and store the current config (and all previous configs associated with previous versions) in config_versions mapping
There was a problem hiding this comment.
v2.1.0 is referring to the governor release, not cairo/scarb
Since we added versioned configs in governor v2.1.0, we have a new storage layout for storing configs. But without the migration, we had to keep both storage variables
Having a storage variable for config as well as another variable for versioned configs is less elegant than just having all configs be versioned (and the initial config is version 0)
No description provided.