Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyclic dev-dep needs help when publishing #81

Closed
jayvdb opened this issue May 9, 2023 · 3 comments
Closed

Cyclic dev-dep needs help when publishing #81

jayvdb opened this issue May 9, 2023 · 3 comments

Comments

@jayvdb
Copy link
Collaborator

jayvdb commented May 9, 2023

We're in the process of publishing a new butane to https://cloudsmith.io, and ran into rust-lang/cargo#4242 , because butane_test_helper is a dev-dep of butane_core.

I am not a fan of the version range trick suggested at rust-lang/cargo#4242 (comment)

So we're going with the "remove dev-deps and publish dirty" approach like rust-lang/cargo#4242 (comment) . https://github.com/rust-lang/futures-rs/tree/master/ci/remove-dev-dependencies is missing now, but it looks like it should be in the git history. Unfortunately not in crates.io

@jayvdb
Copy link
Collaborator Author

jayvdb commented May 9, 2023

I was able to publish with

cargo hack publish --allow-dirty -p butane_core --no-dev-deps
cargo hack publish --allow-dirty -p butane_codegen
cargo hack publish --allow-dirty -p butane_test_helper
cargo hack publish --allow-dirty -p butane --no-verify
cargo hack publish --allow-dirty -p butane_cli

Tried making it a one-liner but ran into taiki-e/cargo-hack#188

@Electron100
Copy link
Owner

I think #84 fixes this. Let me know if you see issues with the approach there.

@Electron100
Copy link
Owner

Closing due to the above. Let me know if I missed anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants