Skip to content
This repository has been archived by the owner on Feb 16, 2025. It is now read-only.

prefix everything with elektra (outside of core) #3124

Closed
7 tasks
markus2330 opened this issue Oct 28, 2019 · 4 comments
Closed
7 tasks

prefix everything with elektra (outside of core) #3124

markus2330 opened this issue Oct 28, 2019 · 4 comments

Comments

@markus2330
Copy link
Contributor

markus2330 commented Oct 28, 2019

Currently we are not consistent in prefixing methods, in the core we usually have prefixes like key, ks and kdb but in other places we sometimes have the elektra prefix (but not always, e.g. keyCompare in libease or keyComment in libmeta).

So I propose to either remove or rename all methods not starting with kdb outside the core:

  • keySetStringF: prefix and move the helpers?
  • include/kdbmeta.h remove all fucntions keyOwner .. keySetCTime
  • keyNameGetOneLevel (in discussion to be removed)
  • include/kdbopmphm.h (keep symbols private)
  • ksPopAtCursor (already in discussion)
  • keyCompare, keyCompareMeta prefix
  • remove keyCompareByOwner and keyCompareByNameOwner
@stale
Copy link

stale bot commented Nov 1, 2020

I mark this issue stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping the issue by writing a message here or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@stale stale bot added the stale label Nov 1, 2020
@markus2330 markus2330 added this to the 0.9.* milestone Nov 2, 2020
@stale stale bot removed the stale label Nov 2, 2020
@kodebach kodebach added the cm2022s for university course label Mar 3, 2021
@markus2330 markus2330 removed the cm2022s for university course label Mar 4, 2021
@markus2330
Copy link
Contributor Author

Actually the big question is if we should also prefix everything inside the core, so elektraKeyNew instead of keyNew.

@markus2330 markus2330 changed the title prefix everything with elektra outside of core prefix everything with elektra (outside of core) May 11, 2021
@stale
Copy link

stale bot commented May 31, 2022

I mark this issue stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping the issue by writing a message here or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@stale stale bot added the stale label May 31, 2022
@stale
Copy link

stale bot commented Jun 18, 2022

I closed this issue now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@stale stale bot closed this as completed Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants