Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

improve elektraPluginFactory #4490

Closed
markus2330 opened this issue Sep 27, 2022 · 2 comments
Closed

improve elektraPluginFactory #4490

markus2330 opened this issue Sep 27, 2022 · 2 comments
Labels

Comments

@markus2330
Copy link
Contributor

markus2330 commented Sep 27, 2022

Furthermore, I propose (maybe even the bigger change in terms of work) that we drop the name "modules". Instead, only the name "plugin" should be used for plugins, even on loader level.

Since elektraModulesLoad already returns a elektraPluginFactory that is a sensible change.

Additionally, I would also change elektraPluginFactory from

typedef Plugin * (*elektraPluginFactory) (void);

to

typedef KeySet * (*elektraPluginFactory) (void);

where the returned KeySet * is the contract of the Plugin to avoid the hacky overload of the get function.
I think that is already mentioned in another issue. This also requires changing elektraPluginExport and elektraPluginOpen, but should be doable without any other changes.

Originally posted by @kodebach in #3486 (comment)

@github-actions
Copy link

I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@github-actions github-actions bot added the stale label Sep 28, 2023
@github-actions
Copy link

I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant