Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getblockheader RPC: current dynamic_parameters fedpegscript and extension_space are empty #1113

Closed
jamesdorfman opened this issue May 2, 2022 · 2 comments
Assignees
Labels

Comments

@jamesdorfman
Copy link
Contributor

On liquidv1, getblockheader returns the following for dynafed blocks:

$ elements-cli getblockheader 4ceca23354fc7821ddd23bb1f84af6c5092fc7a834fe0ba5fe33f362d6a8bc40
{
  "hash": "4ceca23354fc7821ddd23bb1f84af6c5092fc7a834fe0ba5fe33f362d6a8bc40",
   ...
  "dynamic_parameters": {
    "current": {
      "signblockscript": "0020e51211e91d9cf4aec3bdc370a0303acde5d24baedb12235fdd2786885069d91c",
      "max_block_witness": 1325,
      "fedpegscript": "",
      "extension_space": [
      ]
    },
    "proposed": {
       ...
    }
  },
  ...
}

The fedpegscript and extension_space fields are empty. This is incorrect -- they both should have actual values.

@jamesdorfman jamesdorfman self-assigned this May 2, 2022
@andreabonel
Copy link
Contributor

@jamesdorfman I think this was solved by #1114
Can you please confirm and close?

@delta1
Copy link
Member

delta1 commented Apr 5, 2023

Yes I do think this was fixed.

Block 4ceca23354fc7821ddd23bb1f84af6c5092fc7a834fe0ba5fe33f362d6a8bc40 shows it has compact current params (which excludes fedpegscript and extension space)

getblockheader 4ceca23354fc7821ddd23bb1f84af6c5092fc7a834fe0ba5fe33f362d6a8bc40

{
  "hash": "4ceca23354fc7821ddd23bb1f84af6c5092fc7a834fe0ba5fe33f362d6a8bc40",
  "confirmations": 478071,
  "height": 1815750,
 ...
  "dynamic_parameters": {
    "current": {
      "type": "compact",
      "root": "646a50c45abc18cea6b9116b54f4f4f39142be7fc924c2844f72d4759bcd106b",
      "signblockscript": "0020e51211e91d9cf4aec3bdc370a0303acde5d24baedb12235fdd2786885069d91c",
      "max_block_witness": 1325,
      "extra_root": "5615a639dc8fcb963288539533fb031fc8e174680a6c78c2d11f134f38fa47cf"
    },
    "proposed": {
      "type": "null"
    }
  ...
}

Block 1f8d44d6a34987f59cd19061d0af7b8734ab9129737397a95fc85ba38309ca3d shows full dynafed params which has both fedpegscript and extension space

getblockheader 1f8d44d6a34987f59cd19061d0af7b8734ab9129737397a95fc85ba38309ca3d

{
  "hash": "1f8d44d6a34987f59cd19061d0af7b8734ab9129737397a95fc85ba38309ca3d",
  "confirmations": 773900,
  "height": 1517040,
  ...
  "dynamic_parameters": {
    "current": {
      "type": "full",
      "root": "e1255d1ab787f1619c2ce93634659b0b2a1a039150130b0f6f057cfca87fcffb",
      "signblockscript": "0020e51211e91d9cf4aec3bdc370a0303acde5d24baedb12235fdd2786885069d91c",
      "max_block_witness": 1416,
      "extra_root": "7e755ded4e96bdcc0f5db0f6d21a46e3c91ab474f1a8c95a04ad3452e8600fff",
      "fedpeg_program": "a9149e10aa3d2f248e0e42f9bab31e858240e7ed40e487",
      "fedpegscript": "745c87635b21020e0338c96a8870479f2396c373cc7696ba124e8635d41b0ea581112b678172612102675333a4e4b8fb51d9d4e22fa5a8eaced3fdac8a8cbf9be8c030f75712e6af992102896807d54bc55c24981f24a453c60ad3e8993d693732288068a23df3d9f50d4821029e51a5ef5db3137051de8323b001749932f2ff0d34c82e96a2c2461de96ae56c2102a4e1a9638d46923272c266631d94d36bdb03a64ee0e14c7518e49d2f29bc40102102f8a00b269f8c5e59c67d36db3cdc11b11b21f64b4bffb2815e9100d9aa8daf072103079e252e85abffd3c401a69b087e590a9b86f33f574f08129ccbd3521ecf516b2103111cf405b627e22135b3b3733a4a34aa5723fb0f58379a16d32861bf576b0ec2210318f331b3e5d38156da6633b31929c5b220349859cc9ca3d33fb4e68aa08401742103230dae6b4ac93480aeab26d000841298e3b8f6157028e47b0897c1e025165de121035abff4281ff00660f99ab27bb53e6b33689c2cd8dcd364bc3c90ca5aea0d71a62103bd45cddfacf2083b14310ae4a84e25de61e451637346325222747b157446614c2103cc297026b06c71cbfa52089149157b5ff23de027ac5ab781800a578192d175462103d3bde5d63bdb3a6379b461be64dad45eabff42f758543a9645afd42f6d4248282103ed1e8d5109c9ed66f7941bc53cc71137baa76d50d274bda8d5e8ffbd6e61fe9a5f6702c00fb275522103aab896d53a8e7d6433137bbba940f9c521e085dd07e60994579b64a6d992cf79210291b7d0b1b692f8f524516ed950872e5da10fb1b808b5a526dedc6fed1cf29807210386aa9372fbab374593466bc5451dc59954e90787f08060964d95c87ef34ca5bb5368ae",
      "extension_space": [
        "02555f97c44ad9286ef060a02b00e8e6be2626ed3eb9230705d3ca2f977daae61e03cddbc847f64f898b883d717a7f637bedf9ac2ecd243721eada223f1b1790f75b",
        "033fad80bd2b818d1ca8a8d4a25dafcf5e740be07db6788be1f2f15266e3c6805d0253ff3f140ef8f594d54996eab810a82550c79204279920d95681afe699d00da5",
        "03f2d35e88741f930a3938bfa7075377ec2da4f1d7699a779e2cbf7a389195dc67026132199a025299b5e0f4ab3f44294c81c5302f6d45ddda6316c18ae515793cf6",
        "036286d30d20ddcd3e867851936802dd8a2d84846c7e52aece0fc303c6deec9e0402c7581da9d9ac0001e1c560c348b5df07d42de166d74eccd4c3bda467fe84f898",
        "0327b1884b3d743f4859db7c2df07e6e346d61d77fbc46c1da6db113fbbd43d7c50383c832ec502cf0990b199a4e46a45a63bfa6c6eb3f4b231472f144e684d6e9f8",
        "03075f118532928c7ef27a77644a12a87fbada3cd94cf67b2d2ae5cb169ddaefa402882c4fed938b20f3472af337cd7674a99f0aab0ae1803e27e978c52c417ce5e1",
        "02b988448e337c15cd6ac82b4737e3e2b5e92947da2f7fa96a81db7f9be3fabeb202f660c7675a1ed4893df838a5c4c07a287997cbd7dc5d884044b338ed606231bc",
        "0245b763999e3152418b9cd08b5f54c410a072d5e486826823791848e1bb8790610259740ea12e953db0c5fd135c1a9564ce81a318729668811cf54f884c2f980eb8",
        "032f8814144351d5d05ca40c87cbbda67bb5f8b1920a38cf3bd008c1d266bb4682039eb3a0b89656b338c3f4a9fc7bba582dd21935f59471c18e6b43c57e063053d9",
        "03d8b2ed1813370955cfb8dec24b7c5cb34b13fa4545d9e6d47d8c05af56a2c7d2026392f13fefce606c60adadfe9e729e0af84f5f8cb6a35b76be244351635b38f7",
        "03e2a56e47f41eb83af34fb65c4dfb77ac442b01b5134fd92219bd3f4a999c7de5034e93391cea816e5141dace7e5477bbed90c9daa0670b68b7acc8a44af556bbc1",
        "03156b39a4bce80e68c1582aa78f81f0252ccbb039766b5395ee9a0224f41c236d0399a5d1d42f5b6cb587560394e1581eb0c76916db317c0d644a1b9f509a06c4e6",
        "029797b15de24dc43a6556e58159c5aa0b69ea390ccdebcd7be10751d8085da08f03248e52371b2c3bce2478a3c3aaf37e4f0d6ba711e058ba407f44fdaaf280ac95",
        "03d6a14ab496777401e2eae7992404011537860af7b46c3a8fdea65d29fe4bf26c02dca82e552228f3808b1ea9b38b3342b51e9453dcb1414c551ce08bd726311e30",
        "035c9c770ed88e29b364038d68b1c623fbf71e93e6d5357e278e9b64160984ed3c02659aabb69b8413bc46026830ad1e2284901350a75c2bc97906f49cff01503f0f",
        "02a8300f0cff92b23e402459e83c52ec5824de82ee4004cf9d254e788304027ef60389cbda672fa9efea51706863f1d7ae5e5015b2e519003ef0178c99f71be6e8be",
        "03fcba7ecf41bc7e1be4ee122d9d22e3333671eb0a3a87b5cdf099d59874e1940f02b0fb4fe4670c68329441e47acaaa954ff00e3fd547b9ff4e0fe547df2e775ec5",
        "0335f807a1bdc0906adda1a4166f9cdc2aa974a78b15fc29d79a8d7ca529a9600802228dfd7ff95506dd67b1118803eb8ab49352b2e24cd5f38da043847e722009ba",
        "03fcc2963daaf8249bfd220e52c693626254b9295ac4f947ae2e0cddb3046724c102dac03530ac9712a71eafb87766644b61cf4be85d0fdc6a859875b41e7a1dc8e6",
        "02d67fcb027c5d8fe354fb36235192cb4fffabffdcc6ce74be255fe869f62d867503d61d857b2a8cb060fd4b9a98a862f250df5825068665a3c8d93f2ac8a7085888",
        "02cddb51ea42acf38762418939be0a9227f0212ff96a870a2c1d85ec65905a762903d986a2181a38cfef5b5e2a1915aa2d37f193fcbafab9bf311d6138209f316f5b",
        "029ec6dd0c310513b3720800025a7ad9013d60a7fb041f6e9b9d3963485ba286570277247f28eb9481dd21d664093a2bc19a496c7ffebeca0026a1726a5041e671ba",
        "03f9dea372c4a667dcfe234ff8e0410c22341149ff7d8780c46954ff74998fbe440340c4e534906c06b73874cef00a880ab602641c7883de94296f0f601e6517ae7e",
        "027661f1530dfc88b34b0c8f606d215f30fb0edfa116b331ff44b2fbe040893c6f029d3160731eddc316121b2a31c82270baa4bbe7f08549891af3b444eb690b2df1",
        "03f79461a5559f360c407069b92a8075958bf1f70918872d9dd702db145bccbd420395058fc702f126176ae13e0ebed05107288900a5a35b121f62923e58798b7b2f",
        "02d7f049d9e87c861fc9decfbe167cb13ccc87cce99113f69e3a5dca8bb71b6aed03e82197b2e9cc0ee11a59808cfdb52e824445f8fa99e44dc9c30d1e49950ff9d6",
        "0281bfeffcc6841d1355dce039f5d64f72714a4c3adc4d351eaf3c28acbcee15f00270a16ee1cdfc78755a783efbdb66fe822605cc5f53af707e5038615e22b288e2",
        "022d58f7f198f3fe7e0ae45f93aa28fdb483ac25a258663ac593860e11ac1d1abc035049635f866b921f7cd0481c6165f19e14ba52c67f7c4fade1dcd22f9aacea20",
        "02d40ea20996c882a75fd8cd433484bd8af92791752b4c2d2f24660de36a9f3f8202d874a87df633068c2eacceed3345ce5fb2dbc9f94c30b93ef4c844a77f2651c0",
        "024158f76e16888a49492d4913e45c1b4cba19d87dd5bd24346ef601d31d0625370366e9ad4ce16b65a95fb63aae98fdff6bcbd31816d6336039e529a40a828e9851",
        "02d2283a929584cdf557096a7f473ae25c04fd6f73467657c4bc49dfb3095892bd03599136ea1f66a80a2eb1a144458561f4791d2fc5fcd06e32a88c9cb2976c8aac",
        "036f4b5f3ae46163fb53b0d6c19c78ea2fdf49c8b419c354f3c24fa1ce9547e6b80340a79f2477ff2a077fb0b8ebb96714a9aaf242f4b96253260264ed031f2a7ee4",
        "02d6825aaa063083567f6d4f35ea62c2af8d34f67ef4c2afa565791fd7efc5f3a602b1e0d671f91f756a7613797d84c33daddc1dc1df9badf68d4e2c2216a288c923",
        "03effb766a6f3729c220b0ffa156ffa66d656e5ec16f15bc513b8d0b1298c761d20252831192e573788271e235afca8f72736d97e26b3a1406cac34711b6ab670c26",
        "038c245fa632a0b6c2712cbadb6f6e346284ee0fba3202875abd774faee2deca29032ff781357db141528b1c7ea2cfed3ebe6bb9a028954665cfba355bbcf3d14c8e",
        "0356c22fab025b3e661331ed4dcf8645a4a4fd4a2cae69680339e05df209ef4556032d60805593864388d073193fb9fcf66c389813778dcd4a2e93c8fd164d387f7f",
        "0238de9c098e83c4d244294ac394355c8e80b49af10f7c1e23001e6c88be5d45b803bc04885be94ceffbac90178ef18d4dd6958d7488f7861f0994c659412d9e9463",
        "025651f14b6347a000e15473eaf631fd78c9307e07db85e177e31fcde0b3f2a57403d5303909fe1c6665cbc96a538b17274068c8e79757705f68db3df2b561a4c110",
        "03627a4855be1edc657927f30a4a869ad830041c1f0e74ab4670588af9532b8de803444cb85aef9fbba10b3e2662d533858db771010b57b7aedb1ecaa1c5a34918f1",
        "032d9af13c8d5f5316fd27a14bafb8ec55684ef2e3b5c64b2645e088f570e5d2cb0239590f39508465decfd8a1bdc61b42333297e80588ed826ddd43678edfa6caae"
      ]
    },
    "proposed": {
      "type": "null"
    }
...
}

@delta1 delta1 closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants