Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obscure the mainchainrpcpassword value in debug.log (just as with rpcpassword=****) #1205

Closed
opacey opened this issue Jan 31, 2023 · 0 comments · Fixed by #1206
Closed

Obscure the mainchainrpcpassword value in debug.log (just as with rpcpassword=****) #1205

opacey opened this issue Jan 31, 2023 · 0 comments · Fixed by #1206

Comments

@opacey
Copy link
Contributor

opacey commented Jan 31, 2023

Is your feature request related to a problem? Please describe.
The elements log output (i.e. /debug.log) includes a summary of the configuration options just after it launches. These include the fields mainchainrpcpassword and mainchainrpcuser with their values shown in clear text.

Describe the solution you'd like
It would be nice to have these values obscured to prevent unintended disclosure of credentials. Elements already does this for rpcuser and rpcpassword, i.e. "rpcpassword=****", the same methodology may be appropriate.

Describe alternatives you've considered
None

Additional context
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant