Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-0.21: Separate wallet and node #939

Open
apoelstra opened this issue Dec 3, 2020 · 0 comments
Open

Post-0.21: Separate wallet and node #939

apoelstra opened this issue Dec 3, 2020 · 0 comments

Comments

@apoelstra
Copy link
Member

In bitcoin/bitcoin#16367 the various Bitcoin Core were largely separated. In the 0.21 rebase of this PR I added libbitcoin_common_a_SOURCES and libbitcoin_server_a_SOURCES to libbitcoin_wallet_a_SOURCES which partially undid this separation.

The reason for this was that the blocksigning RPCs, while being part of the wallet, need access to the node. Similarly the pegin RPCs also look at the current chain state and even accesses the Bitcoin RPC.

Properly separating these things may be nontrivial. Blocksigning we should likely just move to a separate utility rather than being part of the wallet. Pegin claim management will take more thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@apoelstra and others