You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In bitcoin/bitcoin#16367 the various Bitcoin Core were largely separated. In the 0.21 rebase of this PR I added libbitcoin_common_a_SOURCES and libbitcoin_server_a_SOURCES to libbitcoin_wallet_a_SOURCES which partially undid this separation.
The reason for this was that the blocksigning RPCs, while being part of the wallet, need access to the node. Similarly the pegin RPCs also look at the current chain state and even accesses the Bitcoin RPC.
Properly separating these things may be nontrivial. Blocksigning we should likely just move to a separate utility rather than being part of the wallet. Pegin claim management will take more thought.
The text was updated successfully, but these errors were encountered:
In bitcoin/bitcoin#16367 the various Bitcoin Core were largely separated. In the 0.21 rebase of this PR I added
libbitcoin_common_a_SOURCES
andlibbitcoin_server_a_SOURCES
tolibbitcoin_wallet_a_SOURCES
which partially undid this separation.The reason for this was that the blocksigning RPCs, while being part of the wallet, need access to the node. Similarly the pegin RPCs also look at the current chain state and even accesses the Bitcoin RPC.
Properly separating these things may be nontrivial. Blocksigning we should likely just move to a separate utility rather than being part of the wallet. Pegin claim management will take more thought.
The text was updated successfully, but these errors were encountered: