Add support for blinding pegins #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenroose
force-pushed
the
confidential-pegins
branch
from
7398e0b to
03388cc
Compare
stevenroose
changed the title
instagibbs
reviewed
Jun 13, 2019
|
looks good otherwise, and nice to see the python stuff put to work :P |
Even when -blindedaddresses=0.
Both via blindrawtransaction and rawblindrawtransaction.
stevenroose
force-pushed
the
confidential-pegins
branch
from
6115878 to
a22c76d
Compare
stevenroose
force-pushed
the
confidential-pegins
branch
from
a22c76d to
56358b8
Compare
Yeah nice to see that we can do all that stuff manually. I think the only thing that we can't do without liquid is the blinding, but that should be possible in Rust with rust-secp256k1-zkp. Very excited about that! |
|
@instagibbs build is fine it seems |
|
re:"Always return blind address for "blech32" type" The help for getnewaddress should reflect this. |
|
utACK cc49106 |
instagibbs
added a commit
that referenced
this pull request
Jun 21, 2019
cc49106 Update getnewaddress help message with "blech32" special case (Steven Roose) 56358b8 Add tests for blinding pegin transactions (Steven Roose) a9f589b Add support for blinding pegin transactions (Steven Roose) bf0cc83 Add confidential assets values to listunspent documentation (Steven Roose) 4e84596 Always return blind address for "blech32" type (Steven Roose) Pull request description: Adds pegin handling support for `blindrawtransaction` and `rawblindrawtransaction`. Tree-SHA512: 1138aeedd2d5852108abd53a6afc83524e5f06ad3ab770fd8ab37c97c8dd5c49f78b8d44bdf7cbe2c073e07cd8566bf032526ab6488e99fc02f8b5b154a3fde1
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 3, 2020
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 9, 2020
gwillen
pushed a commit
that referenced
this pull request
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pegin handling support for
blindrawtransactionandrawblindrawtransaction.