-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix liquidv1 sync #720
Merged
stevenroose
merged 2 commits into
ElementsProject:master
from
instagibbs:fix_liquidv1_dyna
Sep 27, 2019
Merged
Fix liquidv1 sync #720
stevenroose
merged 2 commits into
ElementsProject:master
from
instagibbs:fix_liquidv1_dyna
Sep 27, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I could sync liquidv1. However, wouldn't it make more sense to default the |
A single field wasn't given a positive value which meant it considers no peg-ins to be valid.
instagibbs
force-pushed
the
fix_liquidv1_dyna
branch
from
September 26, 2019 13:07
1858e50
to
85de70c
Compare
hadn't realized we had not over-written the deployment inherited by custom chains. Zero'd out the dynafed deployment(now doesn't show up at all in |
stevenroose
added a commit
that referenced
this pull request
Sep 27, 2019
85de70c Don't activate dynafed like custom chains (Gregory Sanders) b73ff4c Fix liquidv1 sync (Gregory Sanders) Pull request description: A single field wasn't given a positive value which meant it considers no peg-ins to be valid. This is something introduced by dynafed. I put in a guess placeholder, the important part is that it's > 0. Tree-SHA512: 5a70b282fcf3a47fb17181eafd74f6f5cc2209f18111d6ae21ca0cac50bf63e4864f694826902e1a9ca032f5686c537653fe080d42a5e6ca946354a74998ebf5
instagibbs
added a commit
that referenced
this pull request
Sep 27, 2019
9e1c98e Don't activate dynafed like custom chains (Gregory Sanders) 200a392 Fix liquidv1 sync (Gregory Sanders) Pull request description: Backport of Fix liquidv1 sync #720 Tree-SHA512: 564653f70d9dbdc63ac5dcff97c2f4a676dcafa61056604043edf05e331e7de70b2df07b9c8be93ae8fad43bf557ddd0eb848d031b04e40f6a26ba923eb94e79
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 6, 2020
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 9, 2020
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 10, 2020
stevenroose
pushed a commit
that referenced
this pull request
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A single field wasn't given a positive value which
meant it considers no peg-ins to be valid. This is something introduced by dynafed.
I put in a guess placeholder, the important part is that it's > 0.