Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix liquidv1 sync #720

Merged
merged 2 commits into from
Sep 27, 2019
Merged

Conversation

instagibbs
Copy link
Collaborator

@instagibbs instagibbs commented Sep 26, 2019

A single field wasn't given a positive value which
meant it considers no peg-ins to be valid. This is something introduced by dynafed.

I put in a guess placeholder, the important part is that it's > 0.

@instagibbs instagibbs added the needs port Needs backport to a different branch label Sep 26, 2019
@stevenroose
Copy link
Member

I could sync liquidv1. However, wouldn't it make more sense to default the -con_dyna_deploy_start value for liquidv1 to never active instead of active from block 1?

A single field wasn't given a positive value which
meant it considers no peg-ins to be valid.
@instagibbs
Copy link
Collaborator Author

hadn't realized we had not over-written the deployment inherited by custom chains. Zero'd out the dynafed deployment(now doesn't show up at all in getblockchaininfo).

stevenroose added a commit that referenced this pull request Sep 27, 2019
85de70c Don't activate dynafed like custom chains (Gregory Sanders)
b73ff4c Fix liquidv1 sync (Gregory Sanders)

Pull request description:

  A single field wasn't given a positive value which
  meant it considers no peg-ins to be valid. This is something introduced by dynafed.

  I put in a guess placeholder, the important part is that it's > 0.

Tree-SHA512: 5a70b282fcf3a47fb17181eafd74f6f5cc2209f18111d6ae21ca0cac50bf63e4864f694826902e1a9ca032f5686c537653fe080d42a5e6ca946354a74998ebf5
@stevenroose stevenroose merged commit 85de70c into ElementsProject:master Sep 27, 2019
instagibbs added a commit that referenced this pull request Sep 27, 2019
9e1c98e Don't activate dynafed like custom chains (Gregory Sanders)
200a392 Fix liquidv1 sync (Gregory Sanders)

Pull request description:

  Backport of Fix liquidv1 sync #720

Tree-SHA512: 564653f70d9dbdc63ac5dcff97c2f4a676dcafa61056604043edf05e331e7de70b2df07b9c8be93ae8fad43bf557ddd0eb848d031b04e40f6a26ba923eb94e79
apoelstra added a commit to apoelstra/elements that referenced this pull request Nov 6, 2020
apoelstra added a commit to apoelstra/elements that referenced this pull request Nov 9, 2020
apoelstra added a commit to apoelstra/elements that referenced this pull request Nov 10, 2020
stevenroose pushed a commit that referenced this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs port Needs backport to a different branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants