Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.18 backport] [HF] Dynafed blocks must have sighash byte #723 #725

Merged
merged 1 commit into from
Sep 30, 2019
Merged

[0.18 backport] [HF] Dynafed blocks must have sighash byte #723 #725

merged 1 commit into from
Sep 30, 2019

Conversation

stevenroose
Copy link
Member

backport of #723

@instagibbs @stevenroose
Dynafed blocks must have sighash byte
8d043f3 
It is not included in the signature hash.
The sighash byte MUST be SIGHASH_ALL to avoid
malleability.
instagibbs added a commit that referenced this pull request Sep 30, 2019
@instagibbs
Merge #725: [0.18 backport] [HF] Dynafed blocks must have sighash byte …
f98b4ee 
…#723

8d043f3 Dynafed blocks must have sighash byte (Gregory Sanders)

Pull request description:

  backport of #723

Tree-SHA512: 87e11261ef06b049656544096c4787b582e5d8898b6bc0f83fa5563a3dc5ef2290bd66e67ac769331c32775aae827aba4c90c3d3c657a7a059c9748b8cb87e52
@instagibbs instagibbs merged commit 8d043f3 into ElementsProject:elements-0.18 Sep 30, 2019
@stevenroose stevenroose deleted the bp18-723 branch February 2, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenroose @instagibbs