[0.18] feature_blocksign.py: Allot for possibility of non-empty block 0.5RTT #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where feelers could be stuck trying to resolve a collision in the tried table that is to an address in the same netgroup as an existing outbound peer. Thanks to Muoi Tran for the original bug report and detailed debug logs to track this down. Github-Pull: #15486 Rebased-From: 4991e3c Tree-SHA512: 2752c9909d55ff63b9143168033d0d3952effba7f911181919eb62291edf822ec54fffbb20e35b5c5f8cb1092d75c496665da00139dbebe5ce402cbea3ad87c5
After 40 minutes, time out a test-before-evict entry and just evict without testing. Otherwise, if we were unable to test an entry for some reason, we might break using feelers altogether. Github-Pull: #15486 Rebased-From: f71fdda Tree-SHA512: 66c61a9f030b1666e98e4fe66dd6cfc5f1d03b2a1ec01567b195903db6e4412ac778f4464ee9ef35ae6faa1ab7e4b18ef7ecb9a7ced29e6494046990aebf7b76
Github-Pull: #15486 Rebased-From: 20e6ea2 Tree-SHA512: 73b37a98cf4d9ede1d39c30d178d63a5a6865dba6cb7a9f33bd1e03445acb708b3007c7cde991b5de96a407262adda23279fe7a1d2ed31b0b5a33b2e97aaba9b
Tree-SHA512: a2c5818dd2fa261b86a177e846e5a58062f1ea3adf3d4fef5ac6f4a503e7f9f143189a0068847f405cc68f9900f983db5c3ab9799a4e29dd41ced09542f57175
Github-Pull: #15548 Rebased-From: fa55104 Tree-SHA512: 195d9d459431ae879a27e26d01962f020ddbbf648da26e52121c4fa7eb3438330f1ce34de431757e5079bf248f7129539e1d1a83c9c795ab57dc8c51545384bb
Github-Pull: #15559 Rebased-From: a4d0fd0 Tree-SHA512: 43f985ccb1af22e416230b8f351396d1fa677ee4e60f6952962ed37e842f5746df8a58ae7c35d6a7518af4b5974ee753b17ec3578394122584ca10e9ed561268
Github-Pull: #15559 Rebased-From: 335931d Tree-SHA512: ebe460e935e33fbbbe725db403654ee65c86a606401e8519e1180551e2ccd43661eb4ad20bf065f2c0c2a8026c3bb3bce796789f8d612e9e197ceb8d541a63a9
Github-Pull: #15582 Rebased-From: c9963ae Tree-SHA512: ed1dcfafb7015de5405112938b04c4009bec3349a8d4e8aca641598ccab31a34c7f16b5045670909fd2e795fc40640a79658ef6b1771e9f21abd0ca759b239b5
Tree-SHA512: a494a9039555b24a7a4f4ecebc2a1b7c47bf8937b2ec583659e4443b49919e6ddd0e276c273ce2f89955f433de300ea0c36216e288309a7fac5b2e3d2534a604
Github-Pull: #15583 Rebased-From: 15c69b1 Tree-SHA512: edef7cafc5a2cb8d3355591a7742ef61454a5dedbb1dc22f6cc6bae42329d887f3f4a054f2aeedf31180051f50b6478d09e204066205699dabc0cb67b0ce4a96
Tree-SHA512: 8ce284bd20cfeee8bfb9f7144c9a4239b460f83ac18df840b417b43b11e8028b649fb056c9266d01ac39a926a8f4e931d0dc3ee302d0c84f5fcb2c7d18126322
Tree-SHA512: 97a6d7193da6f9d84e35e2511d949b08be990e035ffb38a149bf45df085ea41f4c84953ddd7a38b0165574f7168419fc2bd3ad6351f5012d89cf884d055693e7
a756363 [docs] document BIP 61 deprecation (John Newbery) da14d90 [p2p] Enable BIP 61 REJECT messages by default (John Newbery) Pull request description: This PR reverts #14054 following discussion on the bitcoin-dev mailing list. It also adds release notes to clearly document that the `enablebip61` option will be disabled by default in a future release before being removed entirely. Tree-SHA512: 0c9162045a4fb95689a0cb2de19f98a83636c9a6fb7ffa6809773b593c6c00b14e0480683e4d1c48e9b7f90e89cf7c2dca18bff42f5d2da2a43c522039e9f1ee
Github-Pull: #15617 Rebased-From: 054d01d Tree-SHA512: 2c47cf823cc51aee5a224513a0ca2fd1132f4c567d255ead661e88f009dc5d1db73da79b5e65a63b11b222e17292fdff9035a93cb2e53215d9bbb21a5bce7a41
…et when no modal widget is active 98a24a2 gui: Defer removeAndDeleteWallet when no modal widget is active (João Barbosa) Pull request description: 0.18 Backport of #15614 Tree-SHA512: 8f785705325364ecfa37045090f10ca615f457e279789b0ce0d61f2667f491bce9b44f5e5cdeeecf63d61356213d9a97a3578841295cc8480cf42e037c2decb2
This functionality was removed in v0.18.
…dateaddress help be8b9c6 [rpc] Remove deprecated functionality message from validateaddress help (John Newbery) Pull request description: This functionality was removed in v0.18. ACKs for commit be8b9c: MarcoFalke: utACK be8b9c6 fanquake: utACK be8b9c6 Tree-SHA512: 7e30f1e56020aa3a59e736574075191155866788156d0d30eaf963c0a5015ad0de43787c6b73a765319f2dccec0117a2230a312d18ca3f9be3986ce3de4afdb3
Tree-SHA512: 52b66903e169fc3f53f8e4eccb0f765df9a6fbc149ba98fbe7f8b8e7f03e8196ebef8c19ed7412f6d09ddfa4b82e38aa357e1fca6942b0d1d7fe89ea66053556
Tree-SHA512: 0d7a73946d75ac79df65dc6fb5c885353729a3401d985e2d452bf9e5964be7e169ae2cab481cba5307f5d3480d307e1c9e198090f2ede2c9c020543947d44db4
Github-Pull: #15682 Rebased-From: 43ae1e9 Tree-SHA512: 10b7ef7f58b9ded4d6a446f7a03173de6d2ce5d31a09945308b32e250c9ee7550ad2d6ae3aecb0447731a98f2ddfd62a0dcfa61106b6cc1da78d9985407ecf47
Tree-SHA512: f42885f9b866b1172622c4ff2003b1abe5d26e2bfc060b141475761ddfb69b89c99ed5e9d15a23cf4581e77588f77eaecbbea5b7621c1ca22e7a2da6a788e746
Github-Pull: #15644 Rebased-From: 9453018
Github-Pull: #15644 Rebased-From: 6e051f3
This makes orphan processing work like handling getdata messages: After every actual transaction validation attempt, interrupt processing to deal with messages arriving from other peers. Github-Pull: #15644 Rebased-From: 866c805
The existing wallet_resendwallettransactions.py test only tests the resendwallettransactions RPC. It does not test whether transactions are actually rebroadcast, or whether the rebroadcast logic is called on a timer. This commit updates the test to not use the resendwallettransactions RPC and test that transactions are rebroadcast on a timer. Github-Pull: #15646 Rebased-From: 529c1ae
Github-Pull: #15652 Rebased-From: 0440481
Github-Pull: #15652 Rebased-From: 57908a7
…inimum send amount message 9add5a8 Fix feature_pak.py in light of ElementsProject#706 (Gregory Sanders) 817ebcd sendtomainchain_pak: Fix minimum send amount message (Gregory Sanders) Pull request description: backport of ElementsProject#706 Tree-SHA512: a1f16636210eb28c221a442c113a609da906079b3688dc1dc53e33d0409096638a48036032ba7349257a4d599342272df40dd9335bbc9ac1008c439602a94f8a
A single field wasn't given a positive value which meant it considers no peg-ins to be valid.
…Project#720 9e1c98e Don't activate dynafed like custom chains (Gregory Sanders) 200a392 Fix liquidv1 sync (Gregory Sanders) Pull request description: Backport of Fix liquidv1 sync ElementsProject#720 Tree-SHA512: 564653f70d9dbdc63ac5dcff97c2f4a676dcafa61056604043edf05e331e7de70b2df07b9c8be93ae8fad43bf557ddd0eb848d031b04e40f6a26ba923eb94e79
…t#717 0315022 Bump _CLIENT_VERSION_BUILD (Steven Roose) 500a373 Add legacy pak arg for custom chains (Gregory Sanders) Pull request description: backport of ElementsProject#717 Tree-SHA512: 01e20fd612ef9647b005686fc571ccdb8cf7897f8198b336e8f96c914e24fae96344e94bdf8ff96887568e87849538ef816d4a21ed4fbe3c3e6931d5ee7ae9ea
It is not included in the signature hash. The sighash byte MUST be SIGHASH_ALL to avoid malleability.
…ave sighash byte ElementsProject#723 8d043f3 Dynafed blocks must have sighash byte (Gregory Sanders) Pull request description: backport of ElementsProject#723 Tree-SHA512: 87e11261ef06b049656544096c4787b582e5d8898b6bc0f83fa5563a3dc5ef2290bd66e67ac769331c32775aae827aba4c90c3d3c657a7a059c9748b8cb87e52
…hecksums in initpegoutwallet 5c76fc5 Update initpegoutwallet help to describe derivation paths properly. (Gregory Sanders) 651b28c Fix other bug in initpegoutwallet descriptor parsing (Steven Roose) bf86c44 Temp disable pegout descriptors that are not pkh() (Steven Roose) 19c477e Support descriptors with checksums in initpegoutwallet (Steven Roose) Pull request description: Backport of ElementsProject#726. Tree-SHA512: 603c6896f4407c53ef44ebbbab5064827203a1dccaaa8e7e164dfa085a914ef836dde58cfe85877c8c8bccd4aac4f405f42e820a5a8a42caa0ac24bf43e3d475
f7a41c5 finalizecompactblock: Fix it, make test easier to fail (Gregory Sanders) 8bbd5a3 Fix finalizecompactblock filling in more found txs from mempool (Gregory Sanders) e7b77b7 Don't run normal functional tests twice. (Gregory Sanders) 5f628d5 Sprinkle a bunch of syncs to avoid peg-in failure hanging (Gregory Sanders) 87e8060 feature_fedpeg.py: just use testmempoolaccept checking blinded peg-in transactions (Gregory Sanders) 244cccd Take mempool locks when doing compact block RPC calls touching mempool (Gregory Sanders) e66aca4 Disable functional tests for sanitzer runs which just OOM (Gregory Sanders) 12eb9b9 Don't run unit tests for compatibility run(which is a NOP) (Gregory Sanders) Pull request description: 1) Don't run unit tests for compatibility run(redundant) 2) Disable functional tests for sanitizer runs which have been OOM for a while now 3) only use mempool sync in fedpeg test to avoid connection complexity, add a bunch of sync calls to avoid hanging validation failure corner cases 4) run functional tests exactly once 5) fix finalizecompactblock RPC Tree-SHA512: 2c682d3855cd474fb6e8c039a0cc308cf68321da0f57adbbf2aa8e3aa17b06e244942be7e2f8518581ad972fedfa80f4d898e1cd72a95e9660463413a3b47efe
Elements PSBTs are incompatible with normal PSBTs due to differing transaction formats, so use different magic bytes to distinguish.
… method specified in BIP 174 f72e57a Use Elements PSBT magic when in Elements mode (Andrew Chow) 8be2a9e Change Proprietary types to use the method specified in BIP 174 (Andrew Chow) Pull request description: Backport of ElementsProject#730 Tree-SHA512: d0484639049de772989f4f97cc926fbdea0e5c27a294c1f2b5ec0b0f28ca6e620ac5a6306d029ff90d77c1c390848fbad94b3b51fe5e67d4792bb117b000c07b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #747