Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-request]: New gRPC methods #5634

Closed
4 of 7 tasks
niteshbalusu11 opened this issue Sep 26, 2022 · 3 comments · Fixed by #7209
Closed
4 of 7 tasks

[feature-request]: New gRPC methods #5634

niteshbalusu11 opened this issue Sep 26, 2022 · 3 comments · Fixed by #7209
Milestone

Comments

@niteshbalusu11
Copy link

niteshbalusu11 commented Sep 26, 2022

Issue and Steps to Reproduce

@cdecker sorry for the long list, the following methods could really help me out.

Please add/build out new gRPC methods:

  • ListClosedChannels
  • openChannelAbort
  • fundChannelCancel
  • multiFundChannel
  • broadcastChainTransaction

Subscriptions:

  • staticBackups
  • forwards
  • channel events (opens/closes)
  • payments (send/receive)
  • chain transactions
  • Subscribe to probes
@theborakompanioni
Copy link

theborakompanioni commented Jul 7, 2023

* ListClosedChannels

This is already included with bff3b1c 💪

* broadcastChainTransaction

This might have happened in 04e7e28 🚀, depending on if this is what you meant..

I am going to take a leap and add two additional methods to the list..

  • listConfigs
  • paystatus

Should I open separate issues?

@cdecker
Copy link
Member

cdecker commented Nov 7, 2023

I made the RPC methods into a check-list, and checked the ones that are already present. Some of the methods you list need disambiguation, as there is no method broadcastChainTransaction and ProbeNode. Did you copy those from another implementation, it isn't quite clear which method you need.

@niteshbalusu11
Copy link
Author

I made the RPC methods into a check-list, and checked the ones that are already present. Some of the methods you list need disambiguation, as there is no method broadcastChainTransaction and ProbeNode. Did you copy those from another implementation, it isn't quite clear which method you need.

I removed probe (doesn't make sense to have that).
broadcastChainTransaction just wanted to an RPC method that can take a raw tx and broadcast it.

@ShahanaFarooqui ShahanaFarooqui added this to the v24.08 milestone Jun 27, 2024
@ShahanaFarooqui ShahanaFarooqui linked a pull request Jun 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants