Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC does not contain channels when calling ListPeers #6186

Closed
2Fast2BCn opened this issue Apr 18, 2023 · 9 comments
Closed

gRPC does not contain channels when calling ListPeers #6186

2Fast2BCn opened this issue Apr 18, 2023 · 9 comments
Assignees
Labels
cln-grpc in diagnostic issue under diagnostic rust Issue related to rust
Milestone

Comments

@2Fast2BCn
Copy link

gRPC does not contain channels when calling ListPeers.
ListChannels does return channels but there is a lot of data missing.

image

image

@vincenzopalazzo
Copy link
Collaborator

Do you see the channels from the command line?

btw you may want use listpeerchannels

@vincenzopalazzo vincenzopalazzo added the in diagnostic issue under diagnostic label Apr 18, 2023
@2Fast2BCn
Copy link
Author

listpeerchannels doesn't exist in the gPRC?

@2Fast2BCn
Copy link
Author

~/lightning$ l1-cli listpeerchannels
{
   "channels": [
      {
         "peer_id": "025ccc375a25fd633928ccd28fa9d6fcff244ed38218ba0110b77d4426d3bf7c8d",
         "peer_connected": true,
         "state": "CHANNELD_NORMAL",
         "scratch_txid": "bf706745fa111a9dcd30b5e0f13d865c2e1eeb572dbe57ebad9cc876edfb1ce5",
         "last_tx_fee_msat": 183000,
         "feerate": {
            "perkw": 253,
            "perkb": 1012
         },
         "owner": "channeld",
         "short_channel_id": "503x1x0",
         "direction": 0,
         "channel_id": "f45edd83baa8a99a880c5aba58c3e7b8862d445fd9209bcb62b8f1c1b7367b2c",
         "funding_txid": "2c7b36b7c1f1b862cb9b20d95f442d86b8e7c358ba5a0c889aa9a8ba83dd5ef4",
         "funding_outnum": 0,
         "close_to_addr": "bcrt1qzdukl8aex5x93ahgqyy6dk0qw3qs2lg8wq3vgn",
         "close_to": "001413796f9fb9350c58f6e80109a6d9e07441057d07",
         "private": false,
         "opener": "local",
         "alias": {
            "local": "11019303x7274710x50289",
            "remote": "6152384x14637152x15938"
         },
         "features": [
            "option_static_remotekey"
         ],
         "funding": {
            "local_funds_msat": "1000000000msat",
            "remote_funds_msat": "0msat",
            "pushed_msat": 0
         },
         "to_us_msat": 1000000000,
         "min_to_us_msat": 1000000000,
         "max_to_us_msat": 1000000000,
         "total_msat": 1000000000,
         "fee_base_msat": 1,
         "fee_proportional_millionths": 10,
         "dust_limit_msat": 546000,
         "max_total_htlc_in_msat": 18446744073709551615,
         "their_reserve_msat": 10000000,
         "our_reserve_msat": 10000000,
         "spendable_msat": 989460000,
         "receivable_msat": 0,
         "minimum_htlc_in_msat": 0,
         "minimum_htlc_out_msat": 0,
         "maximum_htlc_out_msat": 990000000,
         "their_to_self_delay": 6,
         "our_to_self_delay": 6,
         "max_accepted_htlcs": 483,
         "state_changes": [
            {
               "timestamp": "2023-04-18T08:42:17.786Z",
               "old_state": "CHANNELD_AWAITING_LOCKIN",
               "new_state": "CHANNELD_NORMAL",
               "cause": "user",
               "message": "Lockin complete"
            }
         ],
         "status": [
            "CHANNELD_NORMAL:Channel ready for use. Channel announced."
         ],
         "in_payments_offered": 0,
         "in_offered_msat": 0,
         "in_payments_fulfilled": 0,
         "in_fulfilled_msat": 0,
         "out_payments_offered": 0,
         "out_offered_msat": 0,
         "out_payments_fulfilled": 0,
         "out_fulfilled_msat": 0,
         "htlcs": []
      }
   ]
}

@2Fast2BCn
Copy link
Author

I absolutely need funding_txid and funding_outnum but I cannot find those in the gRPC. I prefer to only use the gRPC if that is possible to make it easy for people to start using Torq in combination with CLN.

@JssDWt
Copy link
Contributor

JssDWt commented Apr 22, 2023

I can confirm the channels from ListPeers are null in the grpc api as well in the current master branch. Also num_channels is 824642151400.

@vincenzopalazzo vincenzopalazzo added cln-grpc rust Issue related to rust labels Apr 23, 2023
@vincenzopalazzo vincenzopalazzo added this to the v23.08 milestone Apr 23, 2023
@2Fast2BCn
Copy link
Author

I'm trying to add ListClosedChannels in PR #6203
Once I'm able to make this work I could probably try to do the same thing for ListPeerChannels

@TonyGiorgio
Copy link
Contributor

Can confirm that listpeerchannels has not been added to the rpc models despite channels being deprecated in listpeers since v23.02.

Can someone please undeprecate channels from listpeers until a solution is available to move to?

@TonyGiorgio
Copy link
Contributor

TonyGiorgio commented Apr 26, 2023

@2Fast2BCn I got something that should be working in #6205

I don't have ListClosedChannels in it, but perhaps some of the fixes I made to it (specifically this commit caa402a) will help you if you rebase on that PR.

@cdecker cdecker self-assigned this Apr 30, 2023
@2Fast2BCn
Copy link
Author

ListPeerChannels got added #6229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cln-grpc in diagnostic issue under diagnostic rust Issue related to rust
Projects
None yet
Development

No branches or pull requests

5 participants