Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: Missing command AddPsbtOutput #6986

Closed
dangeross opened this issue Jan 10, 2024 · 3 comments · Fixed by #7209
Closed

grpc: Missing command AddPsbtOutput #6986

dangeross opened this issue Jan 10, 2024 · 3 comments · Fixed by #7209

Comments

@dangeross
Copy link

Command AddPsbtOutput is missing from cln-grpc and cln-rpc.

@Vayras
Copy link
Contributor

Vayras commented Feb 15, 2024

Hey @dangeross Can I get some info on this issue, I actually would like to work on this one but I would really like to know more about this issue, Thanks

@ErikDeSmedt
Copy link
Contributor

Core Lightning exposes a couple of API's. The most important one is the rpc-interface which is feature-complete.

The issue mentions cln-rpc which is a rust-crate that can be used to query the rpc-interface. The code of this crate is located in the cln-rpc folder. The cln-grpc that exposes the same API using gRPC. It implements both a client and a server.

The addpsbtoutput exists in the rpc-interface but has no counterpart in the cln-rpc and the cln-grpc crate yet.

Most of the code in the cln-rpc and cln-grpc crate is auto-generated.
To fix the issue you must

  1. Create the appropriate schema in doc/schemas. Consult the docs to know what fields you should add. Hint, each field requires an added annotation. The next version of Core Lightning will be 24.05
  2. Run msggen to generate the code
  • python contrib/msggen/msggen/__main__.py bundle $PWD/doc/schemas
  • python contrib/msggen/msggen/__main__.py generate
  1. Review and commit the generated code

@s373nZ
Copy link
Contributor

s373nZ commented Feb 25, 2024

I created an initial PR for this in #7108.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants