Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: routes missing from decode/decodepay generated code #7186

Closed
daywalker90 opened this issue Mar 30, 2024 · 4 comments
Closed

schema: routes missing from decode/decodepay generated code #7186

daywalker90 opened this issue Mar 30, 2024 · 4 comments
Labels
cln-grpc rust Issue related to rust

Comments

@daywalker90
Copy link
Contributor

The schemas for decode and decodepay contain code for routes but the generated code (e.g. in cln-rpc/grpc) for decode/decodepay responses does not have the routes field. I don't see why and also can't find a related error when generating.

https://github.com/ElementsProject/lightning/blob/master/doc/schemas/lightning-decode.json
https://github.com/ElementsProject/lightning/blob/master/doc/schemas/lightning-decodepay.json

@daywalker90
Copy link
Contributor Author

daywalker90 commented Apr 5, 2024

Ok i've seen they are excluded in OverridePatch but i still want them :)

@cdecker
Copy link
Member

cdecker commented Apr 7, 2024

Sure, we can add them, they were just a bit too nested, and we expected to be able to generalize it with the result of the getroute command IIRC.

The goal is to add them, we just need to find the time to do so :-)

@cdecker
Copy link
Member

cdecker commented Apr 7, 2024

Ah I see you are collecting the missing pieces exactly to track and address them. I'll stop bothering you with excuses, thanks for taking the initiative here 🙏

@endothermicdev
Copy link
Collaborator

I believe this was closed with #7317.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cln-grpc rust Issue related to rust
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants