opts: Be more lenient about locktime_max and fee range by default #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
stupid-default-params
branch
from
51837f5 to
f9ede7b
Compare
I still believe that 2 weeks is way too much, but we were promised that these defaults would be slowly reduced to saner values as the stability increases. Signed-off-by: Christian Decker <decker.christian@gmail.com>
cdecker
force-pushed
the
stupid-default-params
branch
from
f9ede7b to
fbe3a92
Compare
Signed-off-by: Christian Decker <decker.christian@gmail.com>
Signed-off-by: Christian Decker <decker.christian@gmail.com>
The fee range can sometimes cause channels to be closed when the estimator jumps. This has been the case a few times in the last months, and causes a number of channels to be closed, and issue reports to be filed. Increasing this from 5x to 10x should get rid of 84%+ of these closures (measured based on 1h windows over the last 6 months and assuming worst case situations). Signed-off-by: Christian Decker <decker.christian@gmail.com>
cdecker
force-pushed
the
stupid-default-params
branch
from
fbe3a92 to
619575b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been brought up a few times, and I think we should at least ensure that the default parameters of the three implementations match. Together with #1551 this obviates all the workarounds I had in the integration testing suite. I still think our old defaults were better, but maybe we can go back to saner defaults over time.
I added the
max_fee_multiplieras an option since it was the only non-configurable parameter that needed to be changed for this.Closes #1110
Closes #1560