Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Buf for Proto Generation #343

Open
YusukeShimizu opened this issue Dec 31, 2024 · 2 comments
Open

Introduce Buf for Proto Generation #343

YusukeShimizu opened this issue Dec 31, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@YusukeShimizu
Copy link
Contributor

YusukeShimizu commented Dec 31, 2024

Our current https://github.com/ElementsProject/peerswap/tree/9dc5c5175d59eabd611c993b09c97fd151f1acf1/peerswaprpc relies on protoc for generating code from .proto files. While protoc has served its purpose,it has several challenges:

  1. Dependency Management: Maintaining imports and managing shared proto files is becoming cumbersome.
  2. Tooling Limitations: Limited support for modern workflows, such as linting, breaking change detection, and streamlined plugin usage.

I would like to properly perform validation on proto, and for that, I believe protovalidate is appropriate. First, it is necessary to migrate to Buf.
Buf offers a more robust and developer-friendly solution for managing proto files and generating code.

@YusukeShimizu YusukeShimizu added the good first issue Good for newcomers label Dec 31, 2024
@shelter2759
Copy link

@YusukeShimizu
Is this issue still valid? Would it be alright if I worked on it?

@YusukeShimizu
Copy link
Contributor Author

Thank you!
Yes, this issue is still valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants