Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreachable code and bug in if-else clause #1324

Closed
tomsbergmanis opened this issue Nov 26, 2024 · 1 comment · Fixed by #1325
Closed

Unreachable code and bug in if-else clause #1324

tomsbergmanis opened this issue Nov 26, 2024 · 1 comment · Fixed by #1325
Labels
bug Something isn't working

Comments

@tomsbergmanis
Copy link

Hi @Quentin-Anthony, in your merge, you broke the if clause by making it evaluate a tuple, making some code unreachable. You should add an/or operator.
image

@tomsbergmanis tomsbergmanis added the bug Something isn't working label Nov 26, 2024
@Quentin-Anthony
Copy link
Member

Looks like this wasn't caused by the merge, but rather: dc4b81f#diff-46c4c76deb18adf1de8e0be6d4229baed5f1f0308e141479f5a993b3d83dd445

Just fixed in #1325. Thanks for pointing this out, and apologies for not testing that one more thoroughly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants