Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and error helpfully when neither use-installed-tools or use-compiled-tools are enabled on rustc_codegen_spirv #3

Closed
fu5ha opened this issue Nov 10, 2020 · 3 comments · Fixed by #4

Comments

@fu5ha
Copy link
Member

fu5ha commented Nov 10, 2020

Right now, we get a fairly unhelpful error originating within the spirv-tools crate that is actually caused by neither of these features being enabled. Should be possible to do a

#[cfg(none(feature = "use-installed-tools", feature = "use-compiled-tools"))]
error!("Enable one of the `use-compiled-tools` or `use-installed-tools` features");

or something to that effect

@DJMcNab
Copy link

DJMcNab commented Nov 12, 2020

I think ideally this would be in a dependency of spirv-tools, because then the error would happen before any compilation errors due to those missing.

@XAMPPRocky
Copy link
Member

I'm currently working changes to the build system that will remove the need for this, as we'll be able to detect whether you have installed tools or not, and build with the appropriate feature.

@khyperia khyperia transferred this issue from EmbarkStudios/rust-gpu Nov 18, 2020
@khyperia
Copy link
Contributor

khyperia commented Nov 18, 2020

The relevant code for the error message @termhn discussed is now in spirv-tools-rs, so, transferred it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants