This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Diffing of configuration data #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent full reload of wireguard (ReplacePeers: true,) as that can break active sessions. This is done with the UpdateOnly and Removed flags to manage peers.
suom1
approved these changes
Jul 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will prevent a full reload of the Wireguard interface (due to
ReplacePeers: true) as that breaks active VPN sessions. The improvement is achieved by using theUpdateOnlyandRemovedattributes ofwgtypes.PeerConfigflags to manage peers.
The breaking of sessions can be tested with ssh while connected to the VPN. The current main branch will cause the ssh session to lag or close while WireGuard handshakes the connection. With the changes no new handshake takes places as connections are persevered.