Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Only enable IP forwarding if it is disabled #31

Merged
merged 1 commit into from
Dec 27, 2019

Conversation

eest
Copy link
Contributor

@eest eest commented Dec 26, 2019

Any value other than 0 is considered enabled:
https://www.kernel.org/doc/Documentation/networking/ip-sysctl.txt

Fixes #30

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Do not unconditonally write to the ip_forward file unless needed since it may be read-only.

Related Issues

#30

@freddd freddd self-requested a review December 27, 2019 08:05
@suom1 suom1 self-requested a review December 27, 2019 13:23
@suom1 suom1 merged commit 8fc4378 into EmbarkStudios:master Dec 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only set sys.net.ipv4.ip_forward if needed
2 participants