This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Set name and label at creation of client. Fixes #48 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes behaviour of the add button from directly creating an configuration to directing the user to an "create configuration" view. If no name is given the default name is used same way as before. This means that the go backend works with the old frontend as well with the new.
Also handle err.
1. Fix bug introduced in last commit. Don't try to json encode data that is already encoded. 2. Honor --max-number-client-config When the creation moved from Clients.svelte to NewClient.svelte the check in returned json for errors got lost. Now it is back.
|
I've introduced 2 bugs in the PR, but fixed them in 7d1c38b I did not want to amend or squash them as the PR was alive. But if you want to merge I suggest they be squashed together. I have tried to fix the error checks, but I do not know that the docker build is failing on. |
suom1
approved these changes
Apr 14, 2020
luna-duclos
approved these changes
Apr 14, 2020
|
Thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes behaviour of the add button from directly creating an
configuration to directing the user to an "create configuration" view.
If no name is given the default name is used same way as before.
This means that the go backend works with the old frontend as well with the new.