Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoldenLayoutComponent.createNewComponent() fails if first component #55

Open
pbklink opened this issue Mar 4, 2020 · 2 comments
Open

GoldenLayoutComponent.createNewComponent() fails if first component #55

pbklink opened this issue Mar 4, 2020 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@pbklink
Copy link
Contributor

pbklink commented Mar 4, 2020

Should
return content[0].instance; // The case when this is the first component.
be
return content.contentItems[0].instance; // The case when this is the first component. ?
@kroky-cs
Copy link

kroky-cs commented Mar 23, 2020 •
edited
Loading

@pbklink This is the right solution, Is there any updates about if it will be fixed and merged soon?

@martin31821
Copy link
Member

accepting PRs, I don't have the time to work at this binding beyond updating the angular versions.

@martin31821 martin31821 added bug Something isn't working help wanted Extra attention is needed labels Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martin31821 @kroky-cs @pbklink