Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golden-layout v2 #78

Open
dpraul opened this issue Feb 10, 2021 · 6 comments
Open

golden-layout v2 #78

dpraul opened this issue Feb 10, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@dpraul
Copy link

dpraul commented Feb 10, 2021

Hi there! Fantastic work on this library (and on golden-layout itself). Now that golden-layout v2 has been released, do you have a roadmap for updating to support the new version? Or is this wrapper effectively unnecessary now?

@martin31821
Copy link
Member

The wrapper is not unneccessary at all, because it does way more than the thing in the angular example.
I intent to update it soon, but I have not decided whether it's going to be before or after the 2.1 release.

For my application I definitely need the popout functionality, before I got that implemented I can't test the wrapper, so it's unlikely to happen so soon.

Also, I'd like to release the 2.0 wrapper as a 0.1 or even 1.0 release here.

@martin31821 martin31821 added the enhancement New feature or request label Feb 10, 2021
@dpraul
Copy link
Author

dpraul commented Feb 10, 2021

Thanks for the update - makes sense! We're also in-need of the popout functionality, and I'm sure others would sorely miss it. We'll keep our eyes out on the 2.1 release (congrats on the 2.0 release, regardless - I know it's a long time coming!)

@martin31821
Copy link
Member

2.1 with the popouts has been released, and I'm trying to update this lib as soon as possible.

@Hegyusz
Copy link

Hegyusz commented Aug 6, 2021

Hi @martin31821! First of all, great work with the library! I'm looking for the wrapper update to support golden-layout v2 (even 2.2?). Do you have any update with the progress?

@puschie286
Copy link

puschie286 commented Aug 13, 2021

Hey, would be nice to see :)
found https://github.com/fresto32/ngx-golden-layout-2/ for 2.+ but there are a lot of backward incompatible changes so would be great if you could update your read.me for migration ❤️

@johnthagen
Copy link

@martin31821 Just checking in if there are any updates on this. We have an Angular 13 app that would be great to migrate to GL2-compatible bindings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants